sensors: Call GenericSensorTest.reset() in a cleanup function. #23629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 15, 2020
This addresses some of the flakiness in the sensors tests, in addition to helping make it easier to find other sources of flakiness. Instead of calling GenericSensorTest.reset() in a `finally` clause, use t.add_cleanup() instead. The latter's behavior is more deterministic (see #17924), and fixes an issue where an EventWatcher would fail an assertion when receiving an unexpected event, and GenericSensorTest.reset() would either not be called or called after other tests had already started running. Bug: 731018 Change-Id: Ifbb95b8067b153b70ecb3e6509f476164afd022e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203378 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#769442}
7a8f034 to
1059839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some of the flakiness in the sensors tests, in addition to
helping make it easier to find other sources of flakiness.
Instead of calling GenericSensorTest.reset() in a
finallyclause, uset.add_cleanup() instead. The latter's behavior is more deterministic (see
#17924), and fixes an issue
where an EventWatcher would fail an assertion when receiving an unexpected
event, and GenericSensorTest.reset() would either not be called or called
after other tests had already started running.
Bug: 731018
Change-Id: Ifbb95b8067b153b70ecb3e6509f476164afd022e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203378
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769442}